fix(cd): add SymbolPackageFormat=snupkg and safe glob for release assets#106
Closed
kieronlanning wants to merge 2 commits into
Closed
fix(cd): add SymbolPackageFormat=snupkg and safe glob for release assets#106kieronlanning wants to merge 2 commits into
kieronlanning wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the CD workflow packaging and release asset collection so GitHub releases reliably include symbol packages and don’t fail due to missing glob matches.
Changes:
- Updates
dotnet packto emit.snupkgfiles by settingSymbolPackageFormat=snupkg. - Collects release assets via a
nullglob-safe Bash array and passes them togh release create.
- dotnet pack without SymbolPackageFormat=snupkg produces .symbols.nupkg, not .snupkg - Use nullglob so the release create doesn't fail if a glob matches nothing Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
kieronlanning
force-pushed
the
fix/cd-snupkg-glob
branch
from
60dd34d to
d931992
Compare
Agent-Logs-Url: https://github.com/kjldev/purview-telemetry-sourcegenerator/sessions/7aa7cf82-b45e-4619-92d2-1a55a51d5779 Co-authored-by: kieronlanning <5364423+kieronlanning@users.noreply.github.com>
auto-merge was automatically disabled
May 24, 2026 17:19
Head branch was pushed to by a user without write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The \Publish GitHub Release\ step failed with:
o matches found for ./artifacts/nuget/*.snupkg\
\dotnet pack --include-symbols\ without /p:SymbolPackageFormat=snupkg\ generates *.symbols.nupkg, not *.snupkg. The bash glob fails hard under \set -euo pipefail.
Fixes